]> Cypherpunks repositories - gostls13.git/commit
syscall: if Setctty, require that Ctty be a child descriptor
authorIan Lance Taylor <iant@golang.org>
Fri, 1 May 2020 19:26:30 +0000 (12:26 -0700)
committerIan Lance Taylor <iant@golang.org>
Fri, 1 May 2020 21:57:29 +0000 (21:57 +0000)
commitbe08e10b3bc07f3a4e7b27f44d53d582e15fd6c7
treeab435cf12ffcc4264f2e4f6064f1788ac473f9b8
parent5c8715f70adf13411668b8de76e5fef78c8e3f32
syscall: if Setctty, require that Ctty be a child descriptor

Ctty was always handled as a child descriptor, but in some cases
passing a parent descriptor would also work. This depended on
unpredictable details of the implementation. Reject those cases to
avoid confusion.

Also reject setting both Setctty and Foreground, as they use Ctty
in incompatible ways. It's unlikely that any programs set both fields,
as they don't make sense together.

Fixes #29458

Change-Id: Ieba2d625711fd4b82c8e65e1feed02fd1fb25e6d
Reviewed-on: https://go-review.googlesource.com/c/go/+/231638
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
doc/go1.15.html
src/os/signal/signal_cgo_test.go
src/syscall/exec_unix.go
src/syscall/exec_unix_test.go