]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: add explicit 'where' to EscStep data for explanations
authorDavid Chase <drchase@google.com>
Fri, 21 Oct 2016 16:01:52 +0000 (12:01 -0400)
committerDavid Chase <drchase@google.com>
Wed, 26 Oct 2016 18:46:59 +0000 (18:46 +0000)
commitbea5252a13f723e08c1cb109cb87105e3bdd4ed0
treea4d933c7d9572e85afbc434cc2ea412d95e5605c
parent6d9c8c926da3abd33e3ec229a8ccd028c7610dc3
cmd/compile: add explicit 'where' to EscStep data for explanations

Sometimes neither the src nor the dst of an escape edge
contains the line number appropriate to the edge, so add
a field so that can be set correctly.

Also updated some of the explanations to be less jargon-y
and perhaps more informative, and folded bug example into
test.

Cleaned up some of the function/method names in esc.go
and did a quick sanity check that each "bundling" function
was actually called often enough to justify its existence.

Fixes #17459.

Change-Id: Ieba53ab0a6ba1f7a6c4962bc0b702ede9cc3a3cc
Reviewed-on: https://go-review.googlesource.com/31660
Run-TryBot: David Chase <drchase@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
src/cmd/compile/internal/gc/esc.go
test/escape_because.go