]> Cypherpunks repositories - gostls13.git/commit
runtime: eliminate arbitrary timeout in TestStackGrowth
authorBryan C. Mills <bcmills@google.com>
Wed, 12 Jan 2022 15:26:04 +0000 (10:26 -0500)
committerBryan Mills <bcmills@google.com>
Wed, 19 Jan 2022 16:23:21 +0000 (16:23 +0000)
commitbec2cc370871b998a131f5f363dab4a14b5f2eb2
tree77de8fb9d0b15be207da69ba24d98aa4e7aea006
parentd93ff73ae207763871bee38590242be968b2e743
runtime: eliminate arbitrary timeout in TestStackGrowth

Instead, allow the test to run up until nearly the test's deadline,
whatever that may be, and then crash with a panic (instead of calling
t.Errorf) to get a useful goroutine dump.

With the arbitrary timeout removed, we can now also run this test in
short mode, reducing its impact on test latency.

Fixes #19381

Change-Id: Ie1fae321a2973fcb9b69a012103363f16214f529
Reviewed-on: https://go-review.googlesource.com/c/go/+/378034
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Austin Clements <austin@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
src/runtime/stack_test.go