]> Cypherpunks repositories - gostls13.git/commit
crypto: check all cpu.X86 flags for features used in assembly
authorFilippo Valsorda <filippo@golang.org>
Sat, 9 Nov 2024 18:16:13 +0000 (19:16 +0100)
committerGopher Robot <gobot@golang.org>
Tue, 19 Nov 2024 15:48:59 +0000 (15:48 +0000)
commitbedde1bee0ce16b46549d182375f4feb3b137f46
tree5ac0a51b8918b5629d88d3dd669dd01facb490e2
parente66229a22af8b4895193aacaf95828de63575957
crypto: check all cpu.X86 flags for features used in assembly

These are most likely redundant, but cmd/compile/internal/amd64's
TestGoAMD64v1 turns them off when clobbering those instructions, so we
need to know to skip the assembly in those cases.

Thankfully we have Avo now that adds a helpful comment with the list of
features used by each generated function!

Also improve the error output of TestGoAMD64v1. It had broken before in
#49402 and had required the exact same patch.

Change-Id: I7fab8f36042cdff630f806723aa1d8124c294f60
Reviewed-on: https://go-review.googlesource.com/c/go/+/626876
Auto-Submit: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Russ Cox <rsc@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Daniel McCarney <daniel@binaryparadox.net>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
src/cmd/compile/internal/amd64/versions_test.go
src/crypto/internal/fips/sha256/sha256block_amd64.go
src/crypto/internal/fips/sha512/sha512block_amd64.go
src/crypto/sha1/sha1block_amd64.go