]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: lookup indirect callees from export data for devirtualization
authorMichael Pratt <mpratt@google.com>
Mon, 15 May 2023 22:00:57 +0000 (18:00 -0400)
committerMichael Pratt <mpratt@google.com>
Fri, 13 Oct 2023 13:56:32 +0000 (13:56 +0000)
commitbfb8924653526d4c154c678f0d0bc491f60f7fce
tree1e420bc7c6b9bbcf9fdcb074c3f3e2045140019a
parent696fb5ead03a4b84e11f2d195bc91838fdd029b2
cmd/compile: lookup indirect callees from export data for devirtualization

Today, the PGO IR graph only contains entries for ir.Func loaded into
the package. This can include functions from transitive dependencies,
but only if they happen to be referenced by something in the current
package. If they are not referenced, noder never bothers to load them.

This leads to a deficiency in PGO devirtualization: some callee methods
are available in transitive dependencies but do not devirtualize because
they happen to not get loaded from export data.

Resolve this by adding an explicit lookup from export data of callees
mentioned in the profile.

I have chosen to do this during loading of the profile for simplicity:
the PGO IR graph always contains all of the functions we might need.
That said, it isn't strictly necessary. PGO devirtualization could do
the lookup lazily if it decides it actually needs a method. This saves
work at the expense of a bit more complexity, but I've chosen the
simpler approach for now as I measured the cost of this as significantly
less than the rest of PGO loading.

For #61577.

Change-Id: Ieafb2a549510587027270ee6b4c3aefd149a901f
Reviewed-on: https://go-review.googlesource.com/c/go/+/497175
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
12 files changed:
src/cmd/compile/internal/inline/inl.go
src/cmd/compile/internal/ir/expr.go
src/cmd/compile/internal/ir/func.go
src/cmd/compile/internal/ir/func_test.go [new file with mode: 0644]
src/cmd/compile/internal/noder/unified.go
src/cmd/compile/internal/pgo/irgraph.go
src/cmd/compile/internal/test/pgo_devirtualize_test.go
src/cmd/compile/internal/test/testdata/pgo/devirtualize/devirt.go
src/cmd/compile/internal/test/testdata/pgo/devirtualize/devirt.pprof
src/cmd/compile/internal/test/testdata/pgo/devirtualize/devirt_test.go
src/cmd/compile/internal/test/testdata/pgo/devirtualize/mult.pkg/mult.go [moved from src/cmd/compile/internal/test/testdata/pgo/devirtualize/mult/mult.go with 100% similarity]
src/cmd/compile/internal/types/pkg.go