]> Cypherpunks repositories - gostls13.git/commit
cmd/go: in TestScript, set $GOEXE instead of $exe
authorBryan C. Mills <bcmills@google.com>
Mon, 10 Jun 2019 16:31:13 +0000 (12:31 -0400)
committerBryan C. Mills <bcmills@google.com>
Mon, 10 Jun 2019 21:00:48 +0000 (21:00 +0000)
commitbff0ae6a0174f48a15ef3dcc661c8458e37a9d4a
tree72bac737c520cc26bbf6de354874d3e65cb44a37
parent5ce1819ccab65ceefa3198bbc78fb4dcac3cca6e
cmd/go: in TestScript, set $GOEXE instead of $exe

$GOEXE exists and is documented in 'go env', so $exe is redundant and
a bit confusing. Notably, mod_modinfo.txt already assumes that GOEXE
is set (even though it isn't), and thus fails on Windows.

After this CL, `go test cmd/go/...` passes on a windows-amd64-2016
builder. However, given that the $PATH on the builder is very minimal
(#32430) and network access is limited, tests that rely on binaries
(such as 'git') or external networking may still be broken.

Updates #25300

Change-Id: I9d80f2a0fbaa8bc35fa2205b6898aeccecda4e94
Reviewed-on: https://go-review.googlesource.com/c/go/+/181542
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
src/cmd/go/script_test.go
src/cmd/go/testdata/script/README
src/cmd/go/testdata/script/build_cache_link.txt
src/cmd/go/testdata/script/build_multi_main.txt
src/cmd/go/testdata/script/install_cleans_build.txt
src/cmd/go/testdata/script/mod_build_versioned.txt
src/cmd/go/testdata/script/test_devnull.txt