]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: don't simplify nilchecks in loops
authorAlexandru Moșoi <mosoi@google.com>
Wed, 23 Mar 2016 10:11:34 +0000 (11:11 +0100)
committerAlexandru Moșoi <alexandru@mosoi.ro>
Wed, 23 Mar 2016 15:51:55 +0000 (15:51 +0000)
commitc1892b9c4b321b03973aa4433ec7cd8fe0a307a9
tree3970c7ea41768e68968cdac65bc56d21346b2b24
parentbaec148767328b9af7442083108466486781e835
cmd/compile: don't simplify nilchecks in loops

khr: Lifting the nil check out of the loop altogether is an admirable
goal, and this rewrite is one step on the way. But without lifting it
out of the loop, the rewrite is just hurting us.

Fixes #14917

Change-Id: Idb917f37d89f50f8e046d5ebd7c092b1e0eb0633
Reviewed-on: https://go-review.googlesource.com/21040
Reviewed-by: Keith Randall <khr@golang.org>
Run-TryBot: Alexandru Moșoi <alexandru@mosoi.ro>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/cmd/compile/internal/ssa/gen/generic.rules
src/cmd/compile/internal/ssa/rewritegeneric.go