]> Cypherpunks repositories - gostls13.git/commit
cmd/dist: use registerStdTestSpecially for normal Go tests only
authorDmitri Shuralyov <dmitshur@golang.org>
Fri, 12 May 2023 17:00:45 +0000 (13:00 -0400)
committerGopher Robot <gobot@golang.org>
Fri, 12 May 2023 23:15:29 +0000 (23:15 +0000)
commitc20b7a072a438d9dd806f2e075e029d1d2b0deec
tree037925cc19d66cc4f5fb90ee082e5244f9f2f3be
parent994eca4883b613ee845abb101ed4c3ffef80e428
cmd/dist: use registerStdTestSpecially for normal Go tests only

It was my oversight in CL 463276 to skip registerStdTestSpecially
packages in the race bench test registration loop. Package testdir
has no benchmarks and doesn't need to be skipped. (And if it had
benchmarks, it's very unlikely they'd need any special handling.)

By now there are more cmd/cgo/internal/... packages that are registered
specially, and there isn't a need for their few benchmarks not to be
used for the purpose of race bench tests. If the 3 benchmarks in
cmd/cgo/internal/test were to require something special, then we can
add it to a new registerRaceBenchTestSpecially map with a comment, and
do register them specially in registerTests instead of forgetting to.

This restores the automatic 'go_test_bench:cmd/cgo/internal/test'
registration and reduces prevalence of registerStdTestSpecially a bit.

For #37486.
For #56844.

Change-Id: I1791fe5bf94cb4b4e0859c5fff4e7a3d5a23723e
Reviewed-on: https://go-review.googlesource.com/c/go/+/494656
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
src/cmd/dist/test.go