]> Cypherpunks repositories - gostls13.git/commit
runtime/pprof: write heap statistics to heap profile always
authorRuss Cox <rsc@golang.org>
Wed, 29 Apr 2015 16:12:23 +0000 (12:12 -0400)
committerRuss Cox <rsc@golang.org>
Wed, 29 Apr 2015 18:07:43 +0000 (18:07 +0000)
commitc26fc88d56ee4f93c98fc8923fe256121e6199cf
tree697f2f19872fa65359ac1b4c164a7243b639b2a4
parentea426dcae194cc796a8054d0c4cca5f488a3e857
runtime/pprof: write heap statistics to heap profile always

The heap statistics were only written if asked for a profile with debug > 0,
but that also prints a stack trace for each profile line, which is comparatively
much noisier. The statistics are short enough and separate enough
(they only appear at the end) and useful enough that we can print them
always.

This means that people using -test.memprofile in tests will get a memory
profile with statistics included now. Pprof won't care, but if people care to
look, the numbers will be there.

This avoids the need for hacks like using -memprofilerate=1 to find
the number of allocations.

Change-Id: I10a4f593403d0315aad11b37c6e554b734caa73f
Reviewed-on: https://go-review.googlesource.com/9491
Reviewed-by: David Chase <drchase@google.com>
doc/go1.5.txt
src/runtime/pprof/pprof.go