]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: make sure shapes have proper indexes for sub-instantiation
authorDan Scales <danscales@google.com>
Wed, 29 Sep 2021 04:14:17 +0000 (21:14 -0700)
committerDan Scales <danscales@google.com>
Wed, 29 Sep 2021 16:09:04 +0000 (16:09 +0000)
commitc2de759581aef5d14fd07b843caf76db3c8a115b
tree3ef78f3bff904fdcaffa8a72c256083b527f0bd5
parentaeb4fbabc0aaa5293dd34821c450855e9ff82230
cmd/compile: make sure shapes have proper indexes for sub-instantiation

The computation for determining the shapes to use at the top of
getInstantation was not always creating shapes with the proper indexes.
If an instantiation is being called from another instantiated function,
we cannot just copy the shape types unchanged, because their indexes may
have changed. So, for type args that already shapes, we still call
Shapify() with the correct index.

Fixes #48645

Change-Id: Ibb61c6f9a3c317220fb85135ca87eb5ad4dcff9e
Reviewed-on: https://go-review.googlesource.com/c/go/+/353030
Trust: Dan Scales <danscales@google.com>
Run-TryBot: Dan Scales <danscales@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
src/cmd/compile/internal/noder/stencil.go
test/typeparam/issue48645a.go [new file with mode: 0644]
test/typeparam/issue48645a.out [new file with mode: 0644]
test/typeparam/issue48645b.go [new file with mode: 0644]