]> Cypherpunks repositories - gostls13.git/commit
[dev.link] cmd/link: do not put static symbols into name lookup table
authorCherry Zhang <cherryyz@google.com>
Fri, 18 Oct 2019 15:19:32 +0000 (11:19 -0400)
committerCherry Zhang <cherryyz@google.com>
Mon, 21 Oct 2019 21:58:03 +0000 (21:58 +0000)
commitc480d32fadb438155e5d5711ec166f58c73853e9
treece884250035913a8856b1e46bf9accded5184f72
parentd56c8149ac3b6c8c074d46853ce8c7b4e03d4b0f
[dev.link] cmd/link: do not put static symbols into name lookup table

Since the previous CL, we will not reference static symbols by
name. Therefore no need to put them into the name lookup table.

On Linux/ARM, in runtime/internal/atomic/sys_linux_arm.s, the
kernelcas function has a definition and a reference written in
two different forms, one with package prefix, one without. This
way, the assembler cannot know they are the same symbol, only the
linker knows. This is quite unusual, unify the names to so the
assembler can resolve it to index.

Change-Id: Ie7223097be6a3b65f3fa43ed4575da9972ef5b69
Reviewed-on: https://go-review.googlesource.com/c/go/+/201998
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
src/cmd/link/internal/loader/loader.go
src/runtime/internal/atomic/sys_linux_arm.s