]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.12] path/filepath: revert "fix Windows-specific Clean bug"
authorIan Lance Taylor <iant@golang.org>
Wed, 20 Feb 2019 02:12:13 +0000 (18:12 -0800)
committerIan Lance Taylor <iant@golang.org>
Tue, 26 Feb 2019 23:44:04 +0000 (23:44 +0000)
commitc55fb33612cd35741a19137b73e77bb226a4635f
treeaeaa8d686e846ba44b5e120302c875bcd78d10de
parent4754cba67f11b913ddab88acf99571401d160fe1
[release-branch.go1.12] path/filepath: revert "fix Windows-specific Clean bug"

Revert CL 137055, which changed Clean("\\somepath\dir\") to return
"\\somepath\dir" on Windows. It's not entirely clear this is correct,
as this path is really "\\server\share\", and as such the trailing
slash may be the path on that share, much like "C:\". In any case, the
change broke existing code, so roll it back for now and rethink for 1.13.

Updates #27791
Updates #30307

Change-Id: I69200b1efe38bdb6d452b744582a2bfbb3acbcec
Reviewed-on: https://go-review.googlesource.com/c/163077
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
(cherry picked from commit 153c0da89bca6726545cf4451053235b552d3d51)
Reviewed-on: https://go-review.googlesource.com/c/163078
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/path/filepath/path.go
src/path/filepath/path_test.go