]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.12] net/http: avoid writing to Transport.ProxyConnectHeader
authorBryan C. Mills <bcmills@google.com>
Tue, 7 Jan 2020 17:03:28 +0000 (12:03 -0500)
committerBryan C. Mills <bcmills@google.com>
Tue, 7 Jan 2020 22:39:30 +0000 (22:39 +0000)
commitc5af2aa0037b39db801154451a3f70982751d988
tree05bd82b3e2f235c8821407eb7784a06af73f881d
parente42221dc7a003b988b1cae7f07650aeaa705247a
[release-branch.go1.12] net/http: avoid writing to Transport.ProxyConnectHeader

Previously, we accidentally wrote the Proxy-Authorization header for
the initial CONNECT request to the shared ProxyConnectHeader map when
it was non-nil.

Updates #36431
Fixes #36433

Change-Id: I5cb414f391dddf8c23d85427eb6973f14c949025
Reviewed-on: https://go-review.googlesource.com/c/go/+/213638
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
(cherry picked from commit 249c85d3aab2ad2d0bcbf36efe606fdd66f25c72)
Reviewed-on: https://go-review.googlesource.com/c/go/+/213677
src/net/http/transport.go
src/net/http/transport_test.go