]> Cypherpunks repositories - gostls13.git/commit
net/http: fix redirect logic to handle mutations of cookies
authorJoe Tsai <joetsai@digital-static.net>
Tue, 18 Oct 2016 21:56:19 +0000 (14:56 -0700)
committerJoe Tsai <thebrokentoaster@gmail.com>
Tue, 25 Oct 2016 23:51:29 +0000 (23:51 +0000)
commitc60d9a33bfd4af38399b4caf76be0ced4c64c839
tree9af658a5f9c2e72f55cbde036b69ced47df79631
parent70d685dc7244d46b3c22c4ac9588e51d76087ded
net/http: fix redirect logic to handle mutations of cookies

In the situation where the Client.Jar is set and the Request.Header
has cookies manually inserted, the redirect logic needs to be
able to apply changes to cookies from "Set-Cookie" headers to both
the Jar and the manually inserted Header cookies.

Since Header cookies lack information about the original domain
and path, the logic in this CL simply removes cookies from the
initial Header if any subsequent "Set-Cookie" matches. Thus,
in the event of cookie conflicts, the logic preserves the behavior
prior to change made in golang.org/cl/28930.

Fixes #17494
Updates #4800

Change-Id: I645194d9f97ff4d95bd07ca36de1d6cdf2f32429
Reviewed-on: https://go-review.googlesource.com/31435
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/net/http/client.go
src/net/http/client_test.go