]> Cypherpunks repositories - gostls13.git/commit
cmd/go/internal/work: support pkgconf 1.4 and later
authorJakub Čajka <jcajka@redhat.com>
Fri, 5 Jan 2018 12:38:55 +0000 (13:38 +0100)
committerIan Lance Taylor <iant@golang.org>
Thu, 19 Apr 2018 17:13:21 +0000 (17:13 +0000)
commitc63e047dac52ff18d55d1c60eef9a8a5e39f0da5
tree9d7ee2f531c13e96cb18bb3849f5e941fe8db975
parent3d8940a9ee791089ad6417b35d9e70ed2bfc7258
cmd/go/internal/work: support pkgconf 1.4 and later

Fixes #23373

Fix interfacing with latest(1.4+) pkgconf versions, as they have change the
output format, by extending parsing function splitPkgConfigOutput to accommodate
more possible fragment escaping formats. Function is based on pkgconfigs own
implementation at
https://github.com/pkgconf/pkgconf/blob/master/libpkgconf/argvsplit.c. Along
with this change test case TestSplitPkgConfigOutput have been expanded. Thanks
to ignatenko for help on test cases and insights in to the pkgconfig.

Change-Id: I55301bb564b07128d5564ec1454dd247f84a95c3
Reviewed-on: https://go-review.googlesource.com/86541
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
src/cmd/go/internal/work/build_test.go
src/cmd/go/internal/work/exec.go