]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.18] cmd/go: prevent go work use panic when given a file
authorJohn Anthony <johnanthony.contrib@gmail.com>
Thu, 17 Mar 2022 15:36:52 +0000 (15:36 +0000)
committerCherry Mui <cherryyz@google.com>
Tue, 5 Apr 2022 14:17:24 +0000 (14:17 +0000)
commitc6ba470316579d80f581ef44b3210b75b3436199
tree8adf4c5e131b04c57862ca4dc61358cb7fe5c482
parent30d9077a3485b1ff7cfd877fcc16ecb64dc3a4ae
[release-branch.go1.18] cmd/go: prevent go work use panic when given a file

The current implementation fails to identify that an argument to go work
use is a file when expecting a directory, and panics when attempting to
access it as a directory. This change checks arguments are directories
and generates an error otherwise.

Fixes #51764
Updates #51749

Change-Id: If8f69d233409e93fcf391a8774bace74c031c986
Reviewed-on: https://go-review.googlesource.com/c/go/+/393615
Reviewed-by: Bryan Mills <bcmills@google.com>
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Trust: Ian Lance Taylor <iant@golang.org>
(cherry picked from commit a84ef500213ef6c2a0e4bfd82253e9fcd28f1f62)
Reviewed-on: https://go-review.googlesource.com/c/go/+/397994
Reviewed-by: Cherry Mui <cherryyz@google.com>
src/cmd/go/internal/workcmd/use.go
src/cmd/go/testdata/script/work_use_file.txt [new file with mode: 0644]