]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.11] cmd/compile: add necessary operand to mergePoint in rewrite...
authorDavid Chase <drchase@google.com>
Wed, 19 Jun 2019 22:09:39 +0000 (18:09 -0400)
committerAlexander Rakoczy <alex@golang.org>
Mon, 8 Jul 2019 17:48:29 +0000 (17:48 +0000)
commitc6e3b48af6c99d714917d450b5631450d04b2746
treed71c957cf7b388d7a68fe7e3113769ce67f76079
parentb3336ef5ab0fe6557ebcc062ae8867d28a91b769
[release-branch.go1.11] cmd/compile: add necessary operand to mergePoint in rewrite rules

A missing operand to mergePoint caused lower to place values
in the wrong blocks.

Includes test, belt+suspenders to do both ssa check and verify
the output (was is how the bug was originally observed).

The fixed bug here is very likely present in Go versions
1.9-1.12 on amd64 and s390x

Updates #32680.
Fixes #32711.

Change-Id: I63e702c4c40602cb795ef71b1691eb704d38ccc7
Reviewed-on: https://go-review.googlesource.com/c/go/+/183059
Run-TryBot: David Chase <drchase@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
(cherry picked from commit 769fda2d5110eef6146d7df3bf0219872c9b0da6)
Reviewed-on: https://go-review.googlesource.com/c/go/+/183242
src/cmd/compile/internal/ssa/gen/AMD64.rules
src/cmd/compile/internal/ssa/gen/S390X.rules
src/cmd/compile/internal/ssa/rewriteAMD64.go
src/cmd/compile/internal/ssa/rewriteS390X.go
test/fixedbugs/issue32680.go [new file with mode: 0644]
test/fixedbugs/issue32680.out [new file with mode: 0644]