]> Cypherpunks repositories - gostls13.git/commit
cmd/go: permit wrongly rejected -Wl,-O... linker flags
authorKai Lüke <kai@kinvolk.io>
Mon, 16 Nov 2020 12:05:13 +0000 (12:05 +0000)
committerIan Lance Taylor <iant@golang.org>
Mon, 16 Nov 2020 15:00:31 +0000 (15:00 +0000)
commitc7233dd063cd8bf24460b280e3929458e64f4315
tree6663dd692dd3722958c351ea9fa96a5a71adc39f
parentf2eea4c1dc37886939c010daff89c03d5a3825be
cmd/go: permit wrongly rejected -Wl,-O... linker flags

A typo caused the validation rule to check against -WL,-O... which is
not a regular flag because the L should be lowercase as in the other
rules. This caused valid linker flags to be rejected and people had to
work around this by filtering their default flags that include, e.g.,
-Wl,-O1 for a simple link optimization.
Fix the typo that wrongly rejected -Wl,-O... but allowed a non-existing
-WL,-O flag.

Change-Id: Ia3bf730f16f5ad98a39d7f17159de17b44075462
GitHub-Last-Rev: 2ec7f2a2b92c9c76e707a71f6c5273aa1d512006
GitHub-Pull-Request: golang/go#42631
Reviewed-on: https://go-review.googlesource.com/c/go/+/270278
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Trust: Jay Conrod <jayconrod@google.com>
src/cmd/go/internal/work/security.go