]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.15] crypto/tls: test key type when casting
authorRoland Shoemaker <roland@golang.org>
Wed, 9 Jun 2021 18:31:27 +0000 (11:31 -0700)
committerDmitri Shuralyov <dmitshur@golang.org>
Mon, 12 Jul 2021 17:19:11 +0000 (17:19 +0000)
commitc77980bc077f3774276ab2deba78d8e6bfe4b3bd
treea2ca6df0c544c5bf9e736c904d143e038df15cbe
parent3d1d0664a58f376c21ec586bb73a8f451fdfde85
[release-branch.go1.15] crypto/tls: test key type when casting

When casting the certificate public key in generateClientKeyExchange,
check the type is appropriate. This prevents a panic when a server
agrees to a RSA based key exchange, but then sends an ECDSA (or
other) certificate.

Updates #47143
Fixes #47144
Fixes CVE-2021-34558

Thanks to Imre Rad for reporting this issue.

Change-Id: Iabccacca6052769a605cccefa1216a9f7b7f6aea
Reviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/1116723
Reviewed-by: Filippo Valsorda <valsorda@google.com>
Reviewed-by: Katie Hockman <katiehockman@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/334030
Trust: Filippo Valsorda <filippo@golang.org>
Run-TryBot: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
src/crypto/tls/key_agreement.go