]> Cypherpunks repositories - gostls13.git/commit
[dev.link] cmd/link: migrate symbol's Value and Align when converting to sym.Symbols
authorCherry Zhang <cherryyz@google.com>
Thu, 26 Mar 2020 18:43:15 +0000 (14:43 -0400)
committerCherry Zhang <cherryyz@google.com>
Fri, 27 Mar 2020 00:06:39 +0000 (00:06 +0000)
commitc7e3d817ab48a6a8a0221d78a54d76bbb4e07e4b
treea3f755e27cb5c9fe236a655ceec4b87d4e61b270
parentc5f692021279ee4c6426130f4525d8053fffcbcf
[dev.link] cmd/link: migrate symbol's Value and Align when converting to sym.Symbols

Currently, in LoadFull we migrate a symbol's Value to sym.Symbol
only for external symbols. And symbol's Align is not migrated at
all. As we move LoadFull forward, there are already places where
we set symbol's Value and Align (e.g. in doelf). Migrate them
correctly.

Currently I think we only set them on external symbols, but as
we move forward I think we'll need to set them on Go symbols as
well.

Change-Id: I63e97e38fc08b653ba9faefe15697944faf21bed
Reviewed-on: https://go-review.googlesource.com/c/go/+/225658
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jeremy Faller <jeremy@golang.org>
src/cmd/link/internal/loader/loader.go