]> Cypherpunks repositories - gostls13.git/commit
cmd/go: remove subcommand prefix from error messages
authorJay Conrod <jayconrod@google.com>
Mon, 13 Sep 2021 17:58:25 +0000 (10:58 -0700)
committerJay Conrod <jayconrod@google.com>
Wed, 15 Sep 2021 00:06:54 +0000 (00:06 +0000)
commitc7f2f51fed15b410dea5f608420858b401887d0a
tree806a02a12def7c05fddce4aac821d686503bac92
parent0bb40b08c4884952d7facce3135ff9e50847763f
cmd/go: remove subcommand prefix from error messages

For example, errors that started before with "go mod download: " now
start with "go: " instead.

Previously, we had a mix of errors with and without subcommand
prefixes, even in packages like modload that ostensibly aren't tied
to any specific command. This change makes usage more consistent,
which makes refactoring much easier.

These prefixes didn't add useful information: the user should know the
subcommand they just ran. But see CL 347152 for an attempt at making
the opposite change: always printing the subcommand prefix.

Note that there are a number of errors that don't start with "go: " or
any subcommand prefix. This CL doesn't affect those.

Change-Id: I16430d8c39ea3f4d0870f55a5205f06fb21943c0
Reviewed-on: https://go-review.googlesource.com/c/go/+/349597
Trust: Jay Conrod <jayconrod@google.com>
Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
94 files changed:
src/cmd/go/internal/base/tool.go
src/cmd/go/internal/bug/bug.go
src/cmd/go/internal/clean/clean.go
src/cmd/go/internal/envcmd/env.go
src/cmd/go/internal/get/get.go
src/cmd/go/internal/list/list.go
src/cmd/go/internal/modcmd/download.go
src/cmd/go/internal/modcmd/edit.go
src/cmd/go/internal/modcmd/editwork.go
src/cmd/go/internal/modcmd/graph.go
src/cmd/go/internal/modcmd/init.go
src/cmd/go/internal/modcmd/tidy.go
src/cmd/go/internal/modcmd/vendor.go
src/cmd/go/internal/modcmd/verify.go
src/cmd/go/internal/modcmd/why.go
src/cmd/go/internal/modget/get.go
src/cmd/go/internal/modget/query.go
src/cmd/go/internal/modload/load.go
src/cmd/go/internal/run/run.go
src/cmd/go/internal/test/test.go
src/cmd/go/internal/test/testflag.go
src/cmd/go/internal/tool/tool.go
src/cmd/go/internal/version/version.go
src/cmd/go/internal/vet/vet.go
src/cmd/go/internal/vet/vetflag.go
src/cmd/go/internal/work/action.go
src/cmd/go/internal/work/build.go
src/cmd/go/internal/work/init.go
src/cmd/go/testdata/script/build_i_deprecate.txt
src/cmd/go/testdata/script/env_unset.txt
src/cmd/go/testdata/script/env_write.txt
src/cmd/go/testdata/script/get_go_file.txt
src/cmd/go/testdata/script/get_insecure_no_longer_supported.txt
src/cmd/go/testdata/script/gopath_install.txt
src/cmd/go/testdata/script/gopath_local.txt
src/cmd/go/testdata/script/govcs.txt
src/cmd/go/testdata/script/list_shadow.txt
src/cmd/go/testdata/script/mod_bad_domain.txt
src/cmd/go/testdata/script/mod_dot.txt
src/cmd/go/testdata/script/mod_download.txt
src/cmd/go/testdata/script/mod_edit.txt
src/cmd/go/testdata/script/mod_get_changes.txt
src/cmd/go/testdata/script/mod_get_deprecate_install.txt
src/cmd/go/testdata/script/mod_get_downgrade.txt
src/cmd/go/testdata/script/mod_get_downgrade_missing.txt
src/cmd/go/testdata/script/mod_get_go_file.txt
src/cmd/go/testdata/script/mod_get_main.txt
src/cmd/go/testdata/script/mod_get_newcycle.txt
src/cmd/go/testdata/script/mod_get_nopkgs.txt
src/cmd/go/testdata/script/mod_get_patch.txt
src/cmd/go/testdata/script/mod_get_patchcycle.txt
src/cmd/go/testdata/script/mod_get_patchmod.txt
src/cmd/go/testdata/script/mod_get_patterns.txt
src/cmd/go/testdata/script/mod_get_pkgtags.txt
src/cmd/go/testdata/script/mod_get_private_vcs.txt
src/cmd/go/testdata/script/mod_get_replaced.txt
src/cmd/go/testdata/script/mod_get_split.txt
src/cmd/go/testdata/script/mod_get_svn.txt
src/cmd/go/testdata/script/mod_get_wild.txt
src/cmd/go/testdata/script/mod_getmode_vendor.txt
src/cmd/go/testdata/script/mod_gonoproxy.txt
src/cmd/go/testdata/script/mod_install_pkg_version.txt
src/cmd/go/testdata/script/mod_invalid_path.txt
src/cmd/go/testdata/script/mod_invalid_path_plus.txt
src/cmd/go/testdata/script/mod_invalid_version.txt
src/cmd/go/testdata/script/mod_list.txt
src/cmd/go/testdata/script/mod_list_sums.txt
src/cmd/go/testdata/script/mod_list_update_nolatest.txt
src/cmd/go/testdata/script/mod_load_badchain.txt
src/cmd/go/testdata/script/mod_outside.txt
src/cmd/go/testdata/script/mod_prefer_compatible.txt
src/cmd/go/testdata/script/mod_proxy_invalid.txt
src/cmd/go/testdata/script/mod_query.txt
src/cmd/go/testdata/script/mod_query_empty.txt
src/cmd/go/testdata/script/mod_query_exclude.txt
src/cmd/go/testdata/script/mod_query_main.txt
src/cmd/go/testdata/script/mod_replace_gopkgin.txt
src/cmd/go/testdata/script/mod_retract_fix_version.txt
src/cmd/go/testdata/script/mod_retract_pseudo_base.txt
src/cmd/go/testdata/script/mod_run_nonmain.txt
src/cmd/go/testdata/script/mod_run_pkg_version.txt
src/cmd/go/testdata/script/mod_sum_readonly.txt
src/cmd/go/testdata/script/mod_sumdb.txt
src/cmd/go/testdata/script/mod_sumdb_file_path.txt
src/cmd/go/testdata/script/mod_tidy_compat.txt
src/cmd/go/testdata/script/mod_tidy_compat_ambiguous.txt
src/cmd/go/testdata/script/mod_tidy_too_new.txt
src/cmd/go/testdata/script/mod_upgrade_patch.txt
src/cmd/go/testdata/script/mod_vendor.txt
src/cmd/go/testdata/script/mod_vendor_auto.txt
src/cmd/go/testdata/script/mod_vendor_embed.txt
src/cmd/go/testdata/script/run_wildcard.txt
src/cmd/go/testdata/script/test_flag.txt
src/cmd/go/testdata/script/test_race_install.txt