]> Cypherpunks repositories - gostls13.git/commit
runtime: ensure sysStat for mheap_.arenas is aligned
authorAustin Clements <austin@google.com>
Tue, 20 Feb 2018 23:16:56 +0000 (18:16 -0500)
committerAustin Clements <austin@google.com>
Wed, 21 Feb 2018 03:27:07 +0000 (03:27 +0000)
commitc823155828e5e6f4f7aa5683edb6f9e5dfd31d28
treef3e6b87353c6dc979d91c65bc81651a0953bf8b1
parent16c5d30c84a7dbba88f89585b0238f52cc6b4494
runtime: ensure sysStat for mheap_.arenas is aligned

We don't want to account the memory for mheap_.arenas because most of
it is never touched, so currently we pass the address of a uint64 on
the heap. However, at least on mips, it's possible for this uint64 to
be unaligned, which causes the atomic add in mSysStatInc to crash.

Fix this by instead passing a nil stat pointer.

Fixes #23946.

Change-Id: I091587df1b3066c330b6bb4d834e4596c407910f
Reviewed-on: https://go-review.googlesource.com/95695
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
src/runtime/malloc.go