]> Cypherpunks repositories - gostls13.git/commit
[dev.link] cmd/link: use generator symbols for the rest of pclntab
authorJeremy Faller <jeremy@golang.org>
Tue, 18 Aug 2020 17:38:04 +0000 (13:38 -0400)
committerJeremy Faller <jeremy@golang.org>
Wed, 30 Sep 2020 20:18:23 +0000 (20:18 +0000)
commitc863e14a6c15e174ac0979ddd7f9530d6a4ec9cc
treefda146da74803548f2e85465e2a0400a73dbc7b5
parente674b7703e48e357cd46939413620f21cb84027d
[dev.link] cmd/link: use generator symbols for the rest of pclntab

Move the rest of pclntab creation to generator symbols. Any savings in
pclntab generation CPU time is eaten by the generators run in Asmb
phase.

Stats for Darwin, cmd/compile:

alloc/op:
Pclntab_GC                   13.9MB ± 0%     6.4MB ± 0%    -53.68%  (p=0.000 n=10+10)

allocs/op
Pclntab_GC                    86.5k ± 0%     61.5k ± 0%    -28.90%  (p=0.000 n=10+10)

liveB:
Pclntab_GC                    24.3M ± 0%     22.9M ± 0%     -5.57%  (p=0.000 n=10+10)

Timing:

Pclntab                   32.1ms ± 2%    24.2ms ± 2%    -24.35%  (p=0.000 n=9+9)
Asmb                      18.3ms ±14%    27.4ms ± 9%    +49.55%  (p=0.000 n=10+10)
TotalTime                  351ms ± 2%     347ms ± 3%       ~     (p=0.200 n=9+8)

Change-Id: I5c6b6df5953f6f255240e07578f1c9f8c5f68500
Reviewed-on: https://go-review.googlesource.com/c/go/+/249023
Trust: Jeremy Faller <jeremy@golang.org>
Run-TryBot: Jeremy Faller <jeremy@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
src/cmd/link/internal/ld/data.go
src/cmd/link/internal/ld/pcln.go