]> Cypherpunks repositories - gostls13.git/commit
bytes, internal/bytealg: simplify Equal
authorJosh Bleecher Snyder <josharian@gmail.com>
Mon, 22 Apr 2019 21:39:55 +0000 (14:39 -0700)
committerJosh Bleecher Snyder <josharian@gmail.com>
Wed, 24 Apr 2019 00:56:36 +0000 (00:56 +0000)
commitca0c449a6b1c6ecc75169f93cffa8a5630740030
treedecb56cb6c8eb3e7e910ee090f3694465af30e60
parentde050717f1b668dfd196f1dc4d18c77d03f3afb4
bytes, internal/bytealg: simplify Equal

The compiler has advanced enough that it is cheaper
to convert to strings than to go through the assembly
trampolines to call runtime.memequal.

Simplify Equal accordingly, and cull dead code from bytealg.

While we're here, simplify Equal's documentation.

Fixes #31587

Change-Id: Ie721d33f9a6cbd86b1d873398b20e7882c2c63e9
Reviewed-on: https://go-review.googlesource.com/c/go/+/173323
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dave Cheney <dave@cheney.net>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
16 files changed:
src/bytes/bytes.go
src/bytes/bytes_test.go
src/bytes/export_test.go
src/cmd/vet/all/whitelist/arm.txt
src/internal/bytealg/equal_386.s
src/internal/bytealg/equal_amd64.s
src/internal/bytealg/equal_amd64p32.s
src/internal/bytealg/equal_arm.s
src/internal/bytealg/equal_arm64.s
src/internal/bytealg/equal_generic.go [new file with mode: 0644]
src/internal/bytealg/equal_mips64x.s
src/internal/bytealg/equal_mipsx.s
src/internal/bytealg/equal_native.go
src/internal/bytealg/equal_ppc64x.s
src/internal/bytealg/equal_s390x.s
src/internal/bytealg/equal_wasm.s