]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: rework reporting of oversized stack frames
authorJosh Bleecher Snyder <josharian@gmail.com>
Thu, 30 Mar 2017 18:46:45 +0000 (11:46 -0700)
committerJosh Bleecher Snyder <josharian@gmail.com>
Fri, 31 Mar 2017 16:31:09 +0000 (16:31 +0000)
commitca33e1097155019d0636a0da805054b4182e9b7d
tree11c8687cb714ec0dc3827a1b78b178e55515e47a
parent8577f81a10f4e5b5736119cdd960c44a5ad600f5
cmd/compile: rework reporting of oversized stack frames

We don't support stack frames over 2GB.
Rather than detect this during backend compilation,
check for it at the end of compilation.
This is arguably a more accurate check anyway,
since it takes into account the full frame,
including local stack, arguments, and arch-specific
rounding, although it's unlikely anyone would ever notice.

Also, rather than reporting the error right away,
take note of it and report it later, at the top level.
This is not relevant now, but it will help with making
the backend concurrent, as the append to the list of
oversized functions can be cheaply protected by a plain mutex.

Updates #15756
Updates #19250

Change-Id: Id3fa21906616d62e9dc66e27a17fd5f83304e96e
Reviewed-on: https://go-review.googlesource.com/38972
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
src/cmd/compile/internal/gc/main.go
src/cmd/compile/internal/gc/pgen.go
src/cmd/compile/internal/gc/subr.go