]> Cypherpunks repositories - gostls13.git/commit
runtime: drop stack-allocated pcvalueCaches
authorAustin Clements <austin@google.com>
Tue, 1 Aug 2023 18:41:42 +0000 (14:41 -0400)
committerGopher Robot <gobot@golang.org>
Mon, 21 Aug 2023 21:06:52 +0000 (21:06 +0000)
commitcaf9e15fb76631ca692f4779135aec5b82a68370
treef1b77567882404e4096eb7f5ccec83449f7a6fa3
parent4a8373c553e8a3b15177f74ac12240bbe320a7ca
runtime: drop stack-allocated pcvalueCaches

Now that pcvalue keeps its cache on the M, we can drop all of the
stack-allocated pcvalueCaches and stop carefully passing them around
between lots of operations. This significantly simplifies a fair
amount of code and makes several structures smaller.

This series of changes has no statistically significant effect on any
runtime Stack benchmarks.

I also experimented with making the cache larger, now that the impact
is limited to the M struct, but wasn't able to measure any
improvements.

This is a re-roll of CL 515277

Change-Id: Ia27529302f81c1c92fb9c3a7474739eca80bfca1
Reviewed-on: https://go-review.googlesource.com/c/go/+/520064
Auto-Submit: Austin Clements <austin@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Austin Clements <austin@google.com>
15 files changed:
src/runtime/debugcall.go
src/runtime/export_test.go
src/runtime/heapdump.go
src/runtime/mbitmap.go
src/runtime/mgcmark.go
src/runtime/mgcstack.go
src/runtime/preempt.go
src/runtime/race.go
src/runtime/stack.go
src/runtime/stkframe.go
src/runtime/symtab.go
src/runtime/symtabinl.go
src/runtime/symtabinl_test.go
src/runtime/trace.go
src/runtime/traceback.go