]> Cypherpunks repositories - gostls13.git/commit
runtime: symbolize wrappers as a last resort in race tracebacks
authorAustin Clements <austin@google.com>
Mon, 22 May 2023 23:12:54 +0000 (19:12 -0400)
committerGopher Robot <gobot@golang.org>
Tue, 23 May 2023 19:14:02 +0000 (19:14 +0000)
commitcb6b45a993a50b4cf24defd92a1afcc49cbf5f25
tree1f1660b72ad90f2bd2f7b5c651c4961a2393b758
parentef2bb813c82d5a96bb0993be83a34bfccb5f8c77
runtime: symbolize wrappers as a last resort in race tracebacks

CL 466099 rewrote stack symbolization in race reports. Prior to this
CL, physical frames consisting entirely of wrapper logical frame would
print the wrapper, even though in other cases we try to avoid
printing wrappers. CL 466099 unintentionally changed this behavior and
now physical frames consisting entirely of wrapper frames instead fail
to symbolize and print "??()".

Fix this by taking the outermost wrapper frame if the entire logical
frame expansion consists of wrappers.

Fixes #60245.

Change-Id: I13de8857e508b757ea10d1fc7a47258d7fddbfdb
Reviewed-on: https://go-review.googlesource.com/c/go/+/497235
Reviewed-by: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Austin Clements <austin@google.com>
Auto-Submit: Austin Clements <austin@google.com>
src/runtime/race.go
src/runtime/race/output_test.go