]> Cypherpunks repositories - gostls13.git/commit
cmd/trace: move viewer data structs into cmd/internal/traceviewer
authorMichael Matloob <matloob@golang.org>
Fri, 19 Jun 2020 21:59:16 +0000 (17:59 -0400)
committerMichael Matloob <matloob@golang.org>
Wed, 12 Aug 2020 18:34:48 +0000 (18:34 +0000)
commitcc700bdc269edc5fd29b14c1866c7f57f6f9b526
treec10794c5ab0487a2da66842b40b3f3afa022b0c8
parentb3de3e52c28b87b7849ef5c030cb280763b549ef
cmd/trace: move viewer data structs into cmd/internal/traceviewer

The ViewerEvent, ViewerData and ViewerFrame structs are moved into
cmd/internal/traceviewer, and renamed Event, Data, and Frame.

The structs are the same, except for the following: A definition
for the JSON "bp" field that's defined in the trace format, but
missing in the structs has been added. Also, the Tid and Pid fields
on Event have been renamed TID and PID to better match Go style.
Finally, the footer field on ViewerData, which hasn't been used
for a while, has been removed.

This CL is in preparation for the usage of these structs by cmd/go's
tracing functionality.

Updates #38714

Change-Id: I345f23617b96d4629b876ae717f89d56a67e05a3
Reviewed-on: https://go-review.googlesource.com/c/go/+/239098
Run-TryBot: Michael Matloob <matloob@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Jay Conrod <jayconrod@google.com>
src/cmd/internal/traceviewer/format.go [new file with mode: 0644]
src/cmd/trace/trace.go
src/cmd/trace/trace_test.go
src/cmd/trace/trace_unix_test.go