]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: remove post-inlining PGO graph dump
authorMichael Pratt <mpratt@google.com>
Fri, 12 May 2023 15:54:47 +0000 (11:54 -0400)
committerMichael Pratt <mpratt@google.com>
Fri, 12 May 2023 20:17:06 +0000 (20:17 +0000)
commitcce67690b82faef7d12a86f20e8e6a158d15f2a3
tree6aa251bfd8b8922ab82c29ffd16ee7675dd1eb37
parent4b6a542048be59fae3b01950ff0359de913d1201
cmd/compile: remove post-inlining PGO graph dump

The RedirectEdges logic is fragile and not quite complete (doesn't
update in-edges), which adds overhead to maintaining this package.

In my opinion, the post-inlining graph doesn't provide as much value as
the pre-inlining graph. Even the latter I am not convinced should be in
the compiler rather than an external tool, but it is comparatively
easier to maintain.

Drop it for now. Perhaps we'll want it back in the future for tracking
follow-up optimizations, but for now keep things simple.

Change-Id: I3133a2eb97893a14a6770547f96a3f1796798d17
Reviewed-on: https://go-review.googlesource.com/c/go/+/494655
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Run-TryBot: Michael Pratt <mpratt@google.com>
src/cmd/compile/internal/inline/inl.go
src/cmd/compile/internal/pgo/irgraph.go