]> Cypherpunks repositories - gostls13.git/commit
html/template: prevent aliasing of parse Trees via AddParseTree
authorSamuel Tan <samueltan@google.com>
Tue, 19 Sep 2017 18:54:47 +0000 (11:54 -0700)
committerRob Pike <r@golang.org>
Wed, 20 Sep 2017 01:52:02 +0000 (01:52 +0000)
commitcd0a5f08293e1bf1fac41ae6438d495318cd52fb
treefd8dbd0a3a0a872ffe174a2789aa61055e7d2459
parent3844e707f699198ba44eaf911cbaf673aed8f286
html/template: prevent aliasing of parse Trees via AddParseTree

Check all associated templates in the set for an existing reference
to the given Tree in AddParseTree before assigning that reference
to a new or existing template. This prevents multiple html/template
Templates from referencing and modifying the same underlying Tree.

While there, fix a few existing unit tests so that they terminate
upon encountering unrecoverable failures.

Fixes #21844

Change-Id: I6b4f6996cf5467113ef94f7b91a6933dbbc21839
Reviewed-on: https://go-review.googlesource.com/64770
Run-TryBot: Rob Pike <r@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rob Pike <r@golang.org>
src/html/template/escape_test.go
src/html/template/template.go