]> Cypherpunks repositories - gostls13.git/commit
go/types: fix Info.Implicits entries
authorgriesemer <gri@golang.org>
Thu, 31 Aug 2017 15:41:51 +0000 (17:41 +0200)
committerRobert Griesemer <gri@golang.org>
Fri, 1 Sep 2017 08:06:49 +0000 (08:06 +0000)
commitcecba84a0da049db4df9c1e8aef32b936ef986ea
tree215d3fdf2e9b818053b5fa9c5d6a0b65a7879f52
parente3f3adedcdbe3649e5de2980e85ab054e9d67acf
go/types: fix Info.Implicits entries

Packages of dot imports don't appear in the Info.Implicits map
since they are already taken care of by the Info.Defs map. Fix
documentation.

Implicitly dot-imported objects of a package shouldn't appear
in the Info.Implicits map because the documentation never said
so and there's no way to map multiple objects to the same
*ast.ImportSpec with the current data structure.

Added missing test for Info.Implicits.

The fix is a trivial one-line deletion, the rest is documentation
and test.

Fixes #21591.

Change-Id: I12a37dab85c531911c9363ec3d58daa095c7eb24
Reviewed-on: https://go-review.googlesource.com/60672
Reviewed-by: Alan Donovan <adonovan@google.com>
src/go/types/api.go
src/go/types/api_test.go
src/go/types/resolver.go