]> Cypherpunks repositories - gostls13.git/commit
[dev.link] cmd/link: experiment new reloc accessors in deadcode pass
authorCherry Zhang <cherryyz@google.com>
Thu, 5 Mar 2020 21:43:37 +0000 (16:43 -0500)
committerCherry Zhang <cherryyz@google.com>
Fri, 13 Mar 2020 01:19:15 +0000 (01:19 +0000)
commitcf5c718cbaa479da9257fa8f16bb081dfc89fd6b
treef538d9caabf93bfdcf2d829a877c5b2d7dc718e0
parentc951514da987b0e4ed629962ed773c6cb47d96f9
[dev.link] cmd/link: experiment new reloc accessors in deadcode pass

There is a small speedup:

(linking cmd/compile)

name       old time/op    new time/op    delta
Deadcode     57.1ms ± 1%    53.5ms ± 1%   -6.44%  (p=0.008 n=5+5)

With this, we don't need a slice to read the relocations, reduce
some allocations.

name       old alloc/op   new alloc/op   delta
Deadcode     4.16MB ± 0%    3.84MB ± 0%   -7.85%  (p=0.008 n=5+5)

Change-Id: Icd41c05682ba3f293a8cb9d2fe818e39d7276e5a
Reviewed-on: https://go-review.googlesource.com/c/go/+/222244
Reviewed-by: Than McIntosh <thanm@google.com>
src/cmd/internal/goobj2/objfile.go
src/cmd/link/internal/ld/deadcode2.go
src/cmd/link/internal/ld/decodesym2.go
src/cmd/link/internal/loader/loader.go