]> Cypherpunks repositories - gostls13.git/commit
path/filepath: change IsAbs("NUL") to return true
authorAlex Brainman <alex.brainman@gmail.com>
Sun, 21 Oct 2018 03:57:58 +0000 (14:57 +1100)
committerAlex Brainman <alex.brainman@gmail.com>
Fri, 2 Nov 2018 07:24:50 +0000 (07:24 +0000)
commitd154ef60a0c88be98c70bbe1c5735fb7b1f45250
treece4550c7a6ee275606f10f3474afc6a576a2a83a
parenta70a2a8ad69f481d5fcaf9e006e224fbab7df754
path/filepath: change IsAbs("NUL") to return true

This CL changes IsAbs to return true for "NUL" and other Windows
reserved filenames (search
https://docs.microsoft.com/en-us/windows/desktop/fileio/naming-a-file
for NUL for details). os.Open("NUL") and os.Stat("NUL") work
regardless of what current directory is, and it is mistake to join
"NUL" with current directory when building full path. Changing
IsAbs("NUL") to return true fixes that mistake.

Fixes #28035

Change-Id: Ife8f8aee48400702613ede8fc6834fd43e6e0f03
Reviewed-on: https://go-review.googlesource.com/c/145220
Run-TryBot: Alex Brainman <alex.brainman@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
src/cmd/go/testdata/script/test_devnull.txt [new file with mode: 0644]
src/path/filepath/path_test.go
src/path/filepath/path_windows.go