]> Cypherpunks repositories - gostls13.git/commit
net/http: fix Server blocking after a Handler's Write fails
authorBrad Fitzpatrick <bradfitz@golang.org>
Tue, 5 Feb 2013 04:26:25 +0000 (20:26 -0800)
committerBrad Fitzpatrick <bradfitz@golang.org>
Tue, 5 Feb 2013 04:26:25 +0000 (20:26 -0800)
commitd1e16d06b4df98930b5c6b0775cdd414dfdebd50
treebfba96a533cb58052009f67b1957d41ed263f212
parenta60ffed9e73a5956b6400ae8863856967982c779
net/http: fix Server blocking after a Handler's Write fails

If a Handle's Write to a ResponseWriter fails (e.g. via a
net.Conn WriteDeadline via WriteTimeout on the Server), the
Server was blocking forever waiting for reads on that
net.Conn, even after a Write failed.

Instead, once we see a Write fail, close the connection,
since it's then dead to us anyway.

Fixes #4741

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/7301043
src/pkg/net/http/serve_test.go
src/pkg/net/http/server.go