]> Cypherpunks repositories - gostls13.git/commit
cmd/trace/v2: make the -pprof actually useful
authorMichael Anthony Knyszek <mknyszek@google.com>
Thu, 11 Apr 2024 21:27:08 +0000 (21:27 +0000)
committerGopher Robot <gobot@golang.org>
Thu, 11 Apr 2024 22:45:16 +0000 (22:45 +0000)
commitd1f2cd8a4968d618caf6757ac648d80f2733e5cb
treebcef632bfcf8b64a7cbced8fc8820b30222215c0
parente14aad1faf6f511e342d124681bc0146e426f9aa
cmd/trace/v2: make the -pprof actually useful

In both the v1 and v2 cmd/trace, pprofMatchingGoroutines will generate
no output at all if the filter name passed to it is the empty string.

This is rather pointless because there are at least two places where we
don't pass a name to filter. Modify pprofMatchingGoroutines to include
*all* goroutines in the trace if the name to filter by is not specified.

For #66782.

Change-Id: I6b72298d676bc93892b075a7426e6e56bc6656c7
Reviewed-on: https://go-review.googlesource.com/c/go/+/578356
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
src/cmd/trace/v2/pprof.go