]> Cypherpunks repositories - gostls13.git/commit
cmd/go/internal/work: disallow testgo binary from installing to GOROOT
authorBryan C. Mills <bcmills@google.com>
Fri, 27 Mar 2020 03:10:32 +0000 (23:10 -0400)
committerBryan C. Mills <bcmills@google.com>
Fri, 27 Mar 2020 15:50:43 +0000 (15:50 +0000)
commitd22086ef5e921ee416e929d693f237971569869e
treec58de845088af5934fb5792782c029a451a02ec4
parentf9197a7043e48b6d2caa5ea1b0a969495f998d48
cmd/go/internal/work: disallow testgo binary from installing to GOROOT

Installing to GOROOT makes tests non-parallelizable, since each test
depends on the installed contents of GOROOT already being up-to-date
and may reasonably assume that those contents do not change over the
course of the test.

Fixes #37573
Updates #30316

Change-Id: I2afe95ad11347bee3bb7c2d77a657db6d691cf05
Reviewed-on: https://go-review.googlesource.com/c/go/+/225897
Reviewed-by: Michael Matloob <matloob@golang.org>
src/cmd/go/go_test.go
src/cmd/go/internal/work/exec.go
src/cmd/go/internal/work/testgo.go
src/cmd/go/script_test.go
src/cmd/go/testdata/script/README
src/cmd/go/testdata/script/get_update_all.txt