]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.18] cmd/compile: allow ineffectual //go:linkname in -lang=go1...
authorMatthew Dempsky <mdempsky@google.com>
Thu, 3 Nov 2022 18:56:43 +0000 (11:56 -0700)
committerMichael Knyszek <mknyszek@google.com>
Wed, 9 Nov 2022 18:44:17 +0000 (18:44 +0000)
commitd2a7a180d38d4a51eb5d8f86bb71bed0ecee09ce
tree82214a19928f8cc847c8713fa68e91f022c477eb
parentca571803a87968b280d74b03cbc820ecf68e069d
[release-branch.go1.18] cmd/compile: allow ineffectual //go:linkname in -lang=go1.17 and older

Prior to Go 1.18, ineffectual //go:linkname directives (i.e.,
directives referring to an undeclared name, or to a declared type or
constant) were treated as noops. In Go 1.18, we changed this into a
compiler error to mitigate accidental misuse.

However, the x/sys repo contained ineffectual //go:linkname directives
up until go.dev/cl/274573, which has caused a lot of user confusion.

It seems a bit late to worry about now, but to at least prevent
further user pain, this CL changes the error message to only apply to
modules using "go 1.18" or newer. (The x/sys repo declared "go 1.12"
at the time go.dev/cl/274573 was submitted.)

For #55889.
Fixes #56556.

Change-Id: Id762fff96fd13ba0f1e696929a9e276dfcba2620
Reviewed-on: https://go-review.googlesource.com/c/go/+/447755
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/447815
src/cmd/compile/internal/noder/noder.go
test/fixedbugs/issue55889.go [new file with mode: 0644]