]> Cypherpunks repositories - gostls13.git/commit
crypto/tls: use illegal param alert for bad compression
authorDaniel McCarney <daniel@binaryparadox.net>
Tue, 29 Apr 2025 18:33:15 +0000 (14:33 -0400)
committerDaniel McCarney <daniel@binaryparadox.net>
Fri, 9 May 2025 20:38:22 +0000 (13:38 -0700)
commitd382f1467960d67a6b5eb25447f689a0ccac371e
treee1f8da07fae5edb74eb290a2478bdfdcb8dd1a58
parent2f2f8fe2e810747fecf6d3366d7b76eb65352ee1
crypto/tls: use illegal param alert for bad compression

Previously if the clientHandshakeState for the TLS 1.2 client code
encountered a server helo message that contained a compression method
other than compressionNone, we would emit an unexpected message alert.

Instead, it seems more appropriate to return an illegal parameter alert.
The server hello message _was_ expected, it just contained a bad
parameter option.

Making this change also allows enabling the InvalidCompressionMethod
bogo test.

Updates #72006

Change-Id: I27a2cd231e4b8762b0d9e2dbd3d8ddd5b87fd5c3
Reviewed-on: https://go-review.googlesource.com/c/go/+/669155
Reviewed-by: Roland Shoemaker <roland@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
src/crypto/tls/bogo_config.json
src/crypto/tls/handshake_client.go