]> Cypherpunks repositories - gostls13.git/commit
test2json: default to "pass" when the test doesn't report failures
authorEli Bendersky <eliben@google.com>
Wed, 28 Aug 2019 19:34:48 +0000 (12:34 -0700)
committerIan Lance Taylor <iant@golang.org>
Sat, 31 Aug 2019 01:06:32 +0000 (01:06 +0000)
commitd47526ed777958aa4a2542382e931eb7b3c4c6a9
tree33fd76eddb0262255cfad669ecd0c86aea746fc0
parentbac5b3f0fe7838ecf6e206fa8d2123c7771eb976
test2json: default to "pass" when the test doesn't report failures

When a test has a TestMain that doesn't run any tests (doesn't invoke
m.Run), `go test` passes, but `go test -json` reports a "fail" event
though the exit code is still 0.

This CL fixes test2json to behave similarly to `go test` in such cases -
no output from the test is taken as "pass" by default, not as "fail".

Fixes #31969

Change-Id: I1829d40fc30dc2879e73974fac416f6a34212ccd
Reviewed-on: https://go-review.googlesource.com/c/go/+/192104
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
src/cmd/internal/test2json/test2json.go
src/cmd/internal/test2json/testdata/benchshort.json
src/cmd/internal/test2json/testdata/empty.json [new file with mode: 0644]
src/cmd/internal/test2json/testdata/empty.test [new file with mode: 0644]