]> Cypherpunks repositories - gostls13.git/commit
cmd/pprof: move cmd/internal/pprof back to cmd/pprof/internal
authorRuss Cox <rsc@golang.org>
Mon, 31 Oct 2016 16:09:03 +0000 (12:09 -0400)
committerRuss Cox <rsc@golang.org>
Wed, 2 Nov 2016 19:09:21 +0000 (19:09 +0000)
commitd5b97f614eb02399f7b4ed6615fae094362d151d
tree25ad6f060a4a3f571b98ef3195f0550e3fa115ce
parent682ffae6db749ba63df4b8bc1739974346bb14d7
cmd/pprof: move cmd/internal/pprof back to cmd/pprof/internal

CL 21870 moved the entire cmd/pprof/internal directory to cmd/internal/pprof
for use by cmd/trace, but really cmd/trace only needed cmd/pprof/internal/profile,
which became cmd/internal/pprof/profile, and then internal/pprof/profile.

Move the rest back under cmd/pprof so that it is clear that no other code
is reaching into the guts of cmd/pprof. Just like functions should not be
exported unless necessary, internals should not be made visible to more
code than necessary.

Raúl Silvera noted after the commit of CL 21870 that only the profile package
should have moved, but there was no followup fix (until now).

Change-Id: I603f4dcb0616df1e5d5eb7372e6fccda57e05079
Reviewed-on: https://go-review.googlesource.com/32453
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
14 files changed:
src/cmd/pprof/internal/commands/commands.go [moved from src/cmd/internal/pprof/commands/commands.go with 98% similarity]
src/cmd/pprof/internal/driver/driver.go [moved from src/cmd/internal/pprof/driver/driver.go with 99% similarity]
src/cmd/pprof/internal/driver/interactive.go [moved from src/cmd/internal/pprof/driver/interactive.go with 99% similarity]
src/cmd/pprof/internal/fetch/fetch.go [moved from src/cmd/internal/pprof/fetch/fetch.go with 98% similarity]
src/cmd/pprof/internal/plugin/plugin.go [moved from src/cmd/internal/pprof/plugin/plugin.go with 100% similarity]
src/cmd/pprof/internal/report/report.go [moved from src/cmd/internal/pprof/report/report.go with 99% similarity]
src/cmd/pprof/internal/report/source.go [moved from src/cmd/internal/pprof/report/source.go with 99% similarity]
src/cmd/pprof/internal/report/source_html.go [moved from src/cmd/internal/pprof/report/source_html.go with 100% similarity]
src/cmd/pprof/internal/svg/svg.go [moved from src/cmd/internal/pprof/svg/svg.go with 100% similarity]
src/cmd/pprof/internal/svg/svgpan.go [moved from src/cmd/internal/pprof/svg/svgpan.go with 100% similarity]
src/cmd/pprof/internal/symbolizer/symbolizer.go [moved from src/cmd/internal/pprof/symbolizer/symbolizer.go with 99% similarity]
src/cmd/pprof/internal/symbolz/symbolz.go [moved from src/cmd/internal/pprof/symbolz/symbolz.go with 100% similarity]
src/cmd/pprof/internal/tempfile/tempfile.go [moved from src/cmd/internal/pprof/tempfile/tempfile.go with 100% similarity]
src/cmd/pprof/pprof.go