]> Cypherpunks repositories - gostls13.git/commit
runtime/pprof: deflake TestGoroutineCounts
authorAustin Clements <austin@google.com>
Tue, 9 May 2017 13:42:16 +0000 (09:42 -0400)
committerAustin Clements <austin@google.com>
Tue, 9 May 2017 15:04:46 +0000 (15:04 +0000)
commitd659682de2c16c2eeec3ea67d0cc8d8cbd052609
tree5e20eb7bcead420a70873ee1cbcfaf24b132abb2
parent9eacd977a0d2329ea5856db7ab9bf5130f7bafcc
runtime/pprof: deflake TestGoroutineCounts

TestGoroutineCounts currently depends on timing to get 100 goroutines
to a known blocking point before taking a profile. This fails
frequently, with different goroutines captured at different stacks.
The test is disabled on openbsd because it was too flaky, but in fact
it flakes on all platforms.

Fix this by using Gosched instead of timing. This is both much more
reliable and makes the test run faster.

Fixes #15156.

Change-Id: Ia6e894196d717655b8fb4ee96df53f6cc8bc5f1f
Reviewed-on: https://go-review.googlesource.com/42953
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/runtime/pprof/pprof_test.go