]> Cypherpunks repositories - gostls13.git/commit
cmd/ld: do not assume that only pe section names start with '.'
authorAlex Brainman <alex.brainman@gmail.com>
Sat, 11 Oct 2014 11:01:04 +0000 (22:01 +1100)
committerAlex Brainman <alex.brainman@gmail.com>
Sat, 11 Oct 2014 11:01:04 +0000 (22:01 +1100)
commitd704bb0dc907d32ca827e97bf506794d809ebce8
treec7091ffa49651fc052aa8d1afcb1e260c1ffc3a4
parentd0ee959ab74f39734ae99fdd3e50bea08b52625d
cmd/ld: do not assume that only pe section names start with '.'

Our current pe object reader assumes that every symbol starting with
'.' is section. It appeared to be true, until now gcc 4.9.1 generates
some symbols with '.' at the front. Change that logic to check other
symbol fields in addition to checking for '.'. I am not an expert
here, but it seems reasonable to me.

Added test, but it is only good, if tested with gcc 4.9.1. Otherwise
the test PASSes regardless.

Fixes #8811.
Fixes #8856.

LGTM=jfrederich, iant, stephen.gutekanst
R=golang-codereviews, jfrederich, stephen.gutekanst, iant
CC=alex.brainman, golang-codereviews
https://golang.org/cl/152410043
misc/cgo/test/cgo_test.go
misc/cgo/test/issue8811.c [new file with mode: 0644]
misc/cgo/test/issue8811.go [new file with mode: 0644]
src/cmd/ld/ldpe.c