]> Cypherpunks repositories - gostls13.git/commit
database/sql: close bad connections in commit or rollback:
authorChris Hines <chris.cs.guy@gmail.com>
Tue, 25 Aug 2015 01:48:39 +0000 (21:48 -0400)
committerBrad Fitzpatrick <bradfitz@golang.org>
Thu, 3 Sep 2015 17:07:37 +0000 (17:07 +0000)
commitd737639c4acce7c9f28de22eabfd623d0ae7ed50
tree66e0ab6142e55f89a25cebe74f126405bac6c34f
parentbf99d8f843ae3dfa7a3a4cd5c17aec79e2b9997f
database/sql: close bad connections in commit or rollback:

Previously Tx.close always passed a nil error to tx.db.putConn. As a
result bad connections were reused, even if the driver returned
driver.ErrBadConn. Adding an err parameter to Tx.close allows it to
receive the driver error from Tx.Commit and Tx.Rollback and pass it
to tx.db.putConn.

Fixes #11264

Change-Id: I142b6b2509fa8d714bbc135cef7281a40803b3b8
Reviewed-on: https://go-review.googlesource.com/13912
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/database/sql/fakedb_test.go
src/database/sql/sql.go
src/database/sql/sql_test.go