]> Cypherpunks repositories - gostls13.git/commit
cmd/dist: skip rebuilding packages during builder testing
authorBryan C. Mills <bcmills@google.com>
Tue, 22 Nov 2022 16:40:42 +0000 (11:40 -0500)
committerGopher Robot <gobot@golang.org>
Mon, 30 Jan 2023 18:44:31 +0000 (18:44 +0000)
commitd75a867395e983c0a420ef3fecf30c98897560d7
treeeebf5a0004336c8268b67e18624460baf9be840d
parentdbfdc446fe70a3639ba00eb3d9141ba10783d7cf
cmd/dist: skip rebuilding packages during builder testing

Since packages in "std" no longer have install targets, checking them
for staleness is somewhat meaningless: if they are not cached they
will be rebuilt anyway, and without installed archives against which
we can compare them the staleness check will not detect builder skew.

It would still be meaningful to check "cmd" for staleness, but
(especially on sharded VM-based builders) that is a fairly expensive
operation relative to its benefit. If we are really interested in
detecting builder skew and/or build reproducibility, we could instead
add a "misc" test (similar to "misc/reboot", or perhaps even a part of
that test) that verifies that bootstrapped binaries are reproducible.

For #57734.
Updates #47257.
Updates #56896.

Change-Id: I8683ee81aefe8fb59cce9484453df9729bdc587c
Reviewed-on: https://go-review.googlesource.com/c/go/+/452775
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Austin Clements <austin@google.com>
src/cmd/dist/test.go