]> Cypherpunks repositories - gostls13.git/commit
runtime: provide room for first 4 syscall parameters in windows usleep2
authorAlex Brainman <alex.brainman@gmail.com>
Thu, 3 Sep 2015 07:48:21 +0000 (17:48 +1000)
committerAlex Brainman <alex.brainman@gmail.com>
Tue, 15 Sep 2015 01:12:32 +0000 (01:12 +0000)
commitd7c12042bf061a861a9217cfcb199e9d35df393e
treeecb1726e627a19f83bbf5adcfe1e1ef4362039aa
parent8fab2929dd97b8fb8fe1837b886115e24e814572
runtime: provide room for first 4 syscall parameters in windows usleep2

Windows amd64 requires all syscall callers to provide room for first
4 parameters on stack. We do that for all our syscalls, except inside
of usleep2. In https://codereview.appspot.com/7563043#msg3 rsc says:

"We don't need the stack alignment and first 4 parameters on amd64
because it's just a system call, not an ordinary function call."

He seems to be wrong on both counts. But alignment is already fixed.
Fix parameter space now too.

Fixes #12444

Change-Id: I66a2a18d2f2c3846e3aa556cc3acc8ec6240bea0
Reviewed-on: https://go-review.googlesource.com/14282
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/runtime/sys_windows_amd64.s