]> Cypherpunks repositories - gostls13.git/commit
database/sql: wrap errors with %w in driverArgsConnLocked
authoraimuz <mr.imuz@gmail.com>
Wed, 21 Feb 2024 02:15:40 +0000 (02:15 +0000)
committerGopher Robot <gobot@golang.org>
Tue, 27 Feb 2024 16:30:20 +0000 (16:30 +0000)
commitd8311c86239eebe36e9882760297fd85197add3c
tree59281f91d8f4624b7e237039f70fd6ce3bde4381
parent856355a9133a3c96efcd35f355637d33c9fde7ea
database/sql: wrap errors with %w in driverArgsConnLocked

Use fmt.Errorf %w verb to wrap errors in driverArgsConnLocked,
which allows for easier unwrapping and checking of error types.

Add tests in sql_test.go to ensure that Stmt.Exec and Stmt.Query
correctly wrap underlying Valuer errors, adhering to the new change.

Fixes #64707.

Change-Id: Id9f80e265735d0849ee7abba63e58e4c26e658ad
GitHub-Last-Rev: 0df367e0fb5b213513d4e0ab7f5a87984798f96d
GitHub-Pull-Request: golang/go#64728
Reviewed-on: https://go-review.googlesource.com/c/go/+/550116
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
src/database/sql/convert.go
src/database/sql/driver/types.go
src/database/sql/sql_test.go