]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.16-security] encoding/xml: prevent infinite loop while decoding
authorKatie Hockman <katie@golang.org>
Mon, 1 Mar 2021 14:54:00 +0000 (09:54 -0500)
committerKatie Hockman <katiehockman@google.com>
Tue, 9 Mar 2021 17:55:05 +0000 (17:55 +0000)
commitd86e53e896eca907ad67300c0bb495e3dd925358
treee7c44836164a2b6139f2a9b08a93607ac94ebd70
parentf21be2fdc6f1becdbed1592ea0b245cdeedc5ac8
[release-branch.go1.16-security] encoding/xml: prevent infinite loop while decoding

This change properly handles a TokenReader which
returns an EOF in the middle of an open XML
element.

Thanks to Sam Whited for reporting this.

Fixes CVE-2021-27918

Change-Id: Id02a3f3def4a1b415fa2d9a8e3b373eb6cb0f433
Reviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/1004594
Reviewed-by: Russ Cox <rsc@google.com>
Reviewed-by: Roland Shoemaker <bracewell@google.com>
Reviewed-by: Filippo Valsorda <valsorda@google.com>
(cherry picked from commit e7ce1f6746223ec7b4caa3b1ece25d9be3864710)
Reviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/1014235
src/encoding/xml/xml.go
src/encoding/xml/xml_test.go