]> Cypherpunks repositories - gostls13.git/commit
runtime/internal/atomic: remove write barrier from Storep1 on s390x
authorAustin Clements <austin@google.com>
Wed, 13 Apr 2016 15:13:39 +0000 (11:13 -0400)
committerAustin Clements <austin@google.com>
Wed, 13 Apr 2016 16:06:51 +0000 (16:06 +0000)
commitd8e8fc292ace5ae59a0da44dfca1dd5b1a71ecf1
tree50270ff31b042abfd057be10b9208953087b59c5
parent6b85a45edc94786c7669823ee47a6ce1156d6a9a
runtime/internal/atomic: remove write barrier from Storep1 on s390x

atomic.Storep1 is not supposed to invoke a write barrier (that's what
atomicstorep is for), but currently does on s390x. This causes a panic
in runtime.mapzero when it tries to use atomic.Storep1 to store what's
actually a scalar.

Fix this by eliminating the write barrier from atomic.Storep1 on
s390x. Also add some documentation to atomicstorep to explain the
difference between these.

Fixes #15270.

Change-Id: I291846732d82f090a218df3ef6351180aff54e81
Reviewed-on: https://go-review.googlesource.com/21993
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Austin Clements <austin@google.com>
Reviewed-by: Michael Munday <munday@ca.ibm.com>
src/runtime/atomic_pointer.go
src/runtime/internal/atomic/atomic_s390x.go