]> Cypherpunks repositories - gostls13.git/commit
go/importer: use correct path when checking if package was already imported
authorRobert Griesemer <gri@golang.org>
Wed, 11 May 2016 00:06:19 +0000 (17:06 -0700)
committerRobert Griesemer <gri@golang.org>
Wed, 11 May 2016 03:29:38 +0000 (03:29 +0000)
commitd958dab095febfe542c6209b023d15f1d0de7128
tree830eec6aaca3d2307547e053e2ffdd04b2e48571
parentb6712946c1b46eb629fb010e65e5b3735f94d171
go/importer: use correct path when checking if package was already imported

The importer uses a global (shared) package map across multiple imports
to determine if a package was imported before. That package map is usually
indexed by package (import) path ('id' in this code). However, the binary
importer was using the incoming (possibly unclean) path.

Fixes #15517.

Change-Id: I0c32a708dfccf345e0353fbda20ad882121e437c
Reviewed-on: https://go-review.googlesource.com/23012
Run-TryBot: Robert Griesemer <gri@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
src/go/internal/gcimporter/bimport.go
src/go/internal/gcimporter/gcimporter.go
src/go/internal/gcimporter/gcimporter_test.go
src/go/internal/gcimporter/testdata/p.go [new file with mode: 0644]