]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: relax reshaping condition
authorCuong Manh Le <cuong.manhle.vn@gmail.com>
Tue, 3 Jun 2025 14:35:20 +0000 (21:35 +0700)
committerGopher Robot <gobot@golang.org>
Mon, 9 Jun 2025 16:29:38 +0000 (09:29 -0700)
commitda0e8c4517178f545ee78b11e3d91e1daa7ce07a
tree0c6249ec0a06ecfd4c1f06215518c6045d024604
parent7800f4f0adbc749be95d13be48524e9702c50bbc
cmd/compile: relax reshaping condition

CL 641955 changes the Unified IR reader to not doing shapify when
reading reshaping expression. However, this condition only matters with
pointer type shaping, which will lose the original type, causes the
reshaping ends up with a completely different type.

This CL relaxes the condition, always allow non-pointer types shaping.

Updates #71184
Fixes #73947

Change-Id: Ib0bafd8932c52d99266f311b6cbfc75c00383f9b
Reviewed-on: https://go-review.googlesource.com/c/go/+/678335
Reviewed-by: Keith Randall <khr@golang.org>
Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Keith Randall <khr@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
src/cmd/compile/internal/noder/reader.go
src/cmd/compile/testdata/script/issue73947.txt [new file with mode: 0644]